-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): enforce no extra semicolons #33095
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(This review is outdated)
0629de2
to
ef87954
Compare
ef87954
to
1c3e3be
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33095 +/- ##
=======================================
Coverage 80.79% 80.79%
=======================================
Files 232 232
Lines 14110 14110
Branches 2453 2453
=======================================
Hits 11400 11400
Misses 2430 2430
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Actually, @kaizencc had a better idea. We can turn off the new rule on the |
I will get this over the finish line @yasuaki640! thank you for this, it is very helpful |
@yasuaki640 I wasn't able to push to your branch, so I made this PR instead: #33101 if you would like your PR to be merged, please cherry-pick this commit |
@yasuaki640 we're gonna get lots of merge conflicts the longer this waits. if you don't have the time, are you ok with me taking this over and adding you as a co-author? |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
@kaizencc |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #.
Reason for this change
Enforced no extra semicolons by adding an eslint rule.
Description of changes
I would like to reduce noise during development by reducing the number of warnings output by the IDE.
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license