chore: add integ test that validates full proxy traversal #33140
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a CLI integ test to validate that `cdk deploy` works in a fully network-isolated environment, with only a proxy to go through. This validates that no parts of the CLI setup ignore the proxy configuration, which would otherwise be hard to test. We achieve the network isolation by running the code inside a Docker container where we use `iptables` to drop all network traffic that doesn't go through the Docker host, where we run a proxy. I temporarily bumped the `tsconfig` `target` to try out the `using` syntax (didn't work out with Jest), but that caused some compiler errors around class member initialization that I fixed as well. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license* Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
rix0rrr
requested a deployment
to
test-pipeline
GitHub Actions
Waiting
aws-cdk-automation
previously requested changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33140 +/- ##
==========================================
- Coverage 81.57% 80.79% -0.78%
==========================================
Files 227 232 +5
Lines 13793 14110 +317
Branches 2419 2453 +34
==========================================
+ Hits 11251 11400 +149
- Misses 2270 2430 +160
- Partials 272 280 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
aws-cdk-automation
added
the
pr/needs-maintainer-review
aws-cdk-automation
previously requested changes
Jan 26, 2025
rix0rrr
added
the
pr-linter/exempt-codecov
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Re-roll of #33092)
Add a CLI integ test to validate that
cdk deployworks in a fully network-isolated environment, with only a proxy to go through.This validates that no parts of the CLI setup ignore the proxy configuration, which would otherwise be hard to test.
We achieve the network isolation by running the code inside a Docker container where we use
iptablesto drop all network traffic that doesn't go through the Docker host, where we run a proxy.I temporarily bumped the
tsconfigtargetto try out theusingsyntax (didn't work out with Jest), but that caused some compiler errors around class member initialization that I fixed as well.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license