Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(toolkit): register valid message codes #33160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kaizencc
Copy link
Contributor

Begins a registry of valid codes that are currently in use within the toolkit, and requires that only registered codes are used.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 24, 2025 23:08
@github-actions github-actions bot added the p2 label Jan 24, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.79%. Comparing base (39e5578) to head (7ca354c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #33160      +/-   ##
==========================================
+ Coverage   80.77%   80.79%   +0.01%     
==========================================
  Files         232      232              
  Lines       14110    14110              
  Branches     2453     2453              
==========================================
+ Hits        11398    11400       +2     
+ Misses       2432     2430       -2     
  Partials      280      280              
Flag Coverage Δ
suite.unit 80.79% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.53% <ø> (+0.02%) ⬆️
packages/aws-cdk-lib/core 82.17% <ø> (ø)

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7ca354c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants