feat(cognito): support password history size #33164

mazyu36 · 2025-01-25T06:23:13Z

Issue # (if applicable)

Closes #33106.

Reason for this change

To enable password reuse prevention settings in Cognito user pools.

Description of changes

Add passwordHistorySize property.

Describe any new or updated permissions being added

No permission update.

Description of how you validated changes

Add unit tests and an integ test.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

codecov · 2025-01-25T06:35:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.79%. Comparing base (bfa0f15) to head (38cada9).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #33164   +/-   ##
=======================================
  Coverage   80.79%   80.79%           
=======================================
  Files         232      232           
  Lines       14110    14110           
  Branches     2453     2453           
=======================================
  Hits        11400    11400           
  Misses       2430     2430           
  Partials      280      280

Flag	Coverage Δ
suite.unit	`80.79% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`79.53% <ø> (ø)`
packages/aws-cdk-lib/core	`82.17% <ø> (ø)`

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

lpizzinidev

Thanks 👍 Couple of nits on docs

packages/aws-cdk-lib/aws-cognito/README.md

Co-authored-by: Luca Pizzini <[email protected]>

moelasmar · 2025-01-26T00:16:45Z

packages/aws-cdk-lib/aws-cognito/lib/user-pool.ts

+      if (props.featurePlan === FeaturePlan.LITE) {
+        throw new Error('`passwordHistorySize` can not be set when `featurePlan` is `FeaturePlan.LITE`.');
+      }
+      if (passwordHistorySize < 0 || passwordHistorySize > 24) {
+        throw new Error(`\`passwordHistorySize\` must be between 0 and 24 (received: ${passwordHistorySize})`);


could you please change the Error to be ValidationError according to the ongoing change the team is doing now .. see tracking issue #32324

Thank you for the comment.

Am I correct in understanding that in this PR, you want to replace all Errors within aws-cognito with ValidationErrors? I was aware that the replacement was in progress, but I thought the maintenance team would handle it, so I left the Errors as they were.

at least do it for the new added throw statements .. I believe we can have both in the sam construct .. and if you like to help more, you can open a new pr to replace the Errors in this construct with the validation error :)

Thank you. I've replaced only the Errors added this time. If this PR is merged before the maintainer starts work, I'm considering creating a PR to replace other Errors in aws-cognito.

Pull request has been modified.

moelasmar

thanks @mazyu36 for your quick response and contribution :)

moelasmar · 2025-01-26T00:44:18Z

@mergify update

mergify · 2025-01-26T00:44:27Z

udpate

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

mergify · 2025-01-26T00:44:35Z

update

✅ Branch has been successfully updated

mergify · 2025-01-26T01:16:32Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mazyu36 · 2025-01-26T02:01:21Z

@Mergifyio requeue

mergify · 2025-01-26T02:01:28Z

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

sender-permission >= write

mazyu36 · 2025-01-26T02:01:59Z

@Mergifyio update

mergify · 2025-01-26T02:02:04Z

update

☑️ Nothing to do

queue-position = -1 [📌 update requirement]
#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]

mazyu36 · 2025-01-26T02:02:30Z

@Mergifyio refresh

mergify · 2025-01-26T02:02:34Z

refresh

✅ Pull request refreshed

aws-cdk-automation · 2025-01-26T03:22:45Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 38cada9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-01-26T03:22:57Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-01-26T03:23:23Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

supportt password history size

57f4647

github-actions bot added feature-request A feature should be added or improved. p2 labels Jan 25, 2025

aws-cdk-automation requested a review from a team January 25, 2025 06:23

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Jan 25, 2025

aws-cdk-automation previously requested changes Jan 25, 2025

View reviewed changes

add readme

06b6ae0

mazyu36 marked this pull request as ready for review January 25, 2025 11:12

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 25, 2025

lpizzinidev approved these changes Jan 25, 2025

View reviewed changes

packages/aws-cdk-lib/aws-cognito/README.md Outdated Show resolved Hide resolved

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jan 25, 2025

Update packages/aws-cdk-lib/aws-cognito/README.md

ee075d4

Co-authored-by: Luca Pizzini <[email protected]>

moelasmar approved these changes Jan 26, 2025

View reviewed changes

moelasmar previously requested changes Jan 26, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 26, 2025

ValidationError

03cccb6

mazyu36 force-pushed the feature/cognito-PasswordHistorySize branch from 4bc10c3 to 03cccb6 Compare January 26, 2025 00:34

moelasmar approved these changes Jan 26, 2025

View reviewed changes

Merge branch 'main' into feature/cognito-PasswordHistorySize

b0d4087

Merge branch 'main' into feature/cognito-PasswordHistorySize

38cada9

mergify bot merged commit 988043e into aws:main Jan 26, 2025
20 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Jan 26, 2025

mazyu36 deleted the feature/cognito-PasswordHistorySize branch January 26, 2025 03:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cognito): support password history size #33164

feat(cognito): support password history size #33164

mazyu36 commented Jan 25, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

codecov bot commented Jan 25, 2025 •

edited

Loading

lpizzinidev left a comment •

edited

Loading

moelasmar Jan 26, 2025

mazyu36 Jan 26, 2025

moelasmar Jan 26, 2025 •

edited

Loading

mazyu36 Jan 26, 2025

moelasmar left a comment

moelasmar commented Jan 26, 2025 •

edited

Loading

mergify bot commented Jan 26, 2025

mergify bot commented Jan 26, 2025

mergify bot commented Jan 26, 2025

mazyu36 commented Jan 26, 2025

mergify bot commented Jan 26, 2025

mazyu36 commented Jan 26, 2025

mergify bot commented Jan 26, 2025

mazyu36 commented Jan 26, 2025

mergify bot commented Jan 26, 2025

aws-cdk-automation commented Jan 26, 2025

mergify bot commented Jan 26, 2025

github-actions bot commented Jan 26, 2025

feat(cognito): support password history size #33164

feat(cognito): support password history size #33164

Conversation

mazyu36 commented Jan 25, 2025 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

aws-cdk-automation left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Jan 25, 2025 • edited Loading

Codecov Report

lpizzinidev left a comment • edited Loading

Choose a reason for hiding this comment

moelasmar Jan 26, 2025

Choose a reason for hiding this comment

mazyu36 Jan 26, 2025

Choose a reason for hiding this comment

moelasmar Jan 26, 2025 • edited Loading

Choose a reason for hiding this comment

mazyu36 Jan 26, 2025

Choose a reason for hiding this comment

moelasmar left a comment

Choose a reason for hiding this comment

moelasmar commented Jan 26, 2025 • edited Loading

mergify bot commented Jan 26, 2025

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

mergify bot commented Jan 26, 2025

✅ Branch has been successfully updated

mergify bot commented Jan 26, 2025

mazyu36 commented Jan 26, 2025

mergify bot commented Jan 26, 2025

❌ Command disallowed due to command restrictions in the Mergify configuration.

mazyu36 commented Jan 26, 2025

mergify bot commented Jan 26, 2025

☑️ Nothing to do

mazyu36 commented Jan 26, 2025

mergify bot commented Jan 26, 2025

✅ Pull request refreshed

aws-cdk-automation commented Jan 26, 2025

AWS CodeBuild CI Report

mergify bot commented Jan 26, 2025

github-actions bot commented Jan 26, 2025

mazyu36 commented Jan 25, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

codecov bot commented Jan 25, 2025 •

edited

Loading

lpizzinidev left a comment •

edited

Loading

moelasmar Jan 26, 2025 •

edited

Loading

moelasmar commented Jan 26, 2025 •

edited

Loading