-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: modify module-checks to support Typescript modules #15
chore: modify module-checks to support Typescript modules #15
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Is this ready to go?
I haven't tested it yet with any Typescript module. I was gonna create an example module, but it might be more efficient to just merge #13 and then use that to test this PR. |
Deal. |
@@ -0,0 +1,23 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Awesome, we now support typescript! 😍
Describe your changes
module-checks.yml
to support Typescript in addition to Pythonvalidate.sh
to support runningeslint
fmops
modulefmops
module to adhere to the standardsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.