[corejs3] Do no injected constructor polyfills for static props #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
commented
Jan 25, 2024
| @@ -1,7 +1,6 @@ | |||
| import "core-js/modules/es.array.iterator.js"; | |||
| import "core-js/modules/es.array-buffer.slice.js"; | |||
| import "core-js/modules/es.object.to-string.js"; | |||
| import "core-js/modules/es.typed-array.int8-array.js"; | |||
There was a problem hiding this comment.
@zloirock Does Int8Array.of(); need this polyfill?
There was a problem hiding this comment.
Yes, since in some cases required fixing or complete replacement of typed arrays. In core-js@4 it will not be required since, unlike core-js@3, that relies on the presence of a basic typed arrays support.
There was a problem hiding this comment.
I updated the deps list to add it back.
nicolo-ribaudo
force-pushed
the
unnecessary-symbol-polyfill
branch
5 times, most recently
from
9c8eb95 to
34ba89b
Compare
liuxingbaoyu
approved these changes
Feb 22, 2024
|
If we take this into consideration it might be better to implement "skip sub-paths". |
nicolo-ribaudo
force-pushed
the
unnecessary-symbol-polyfill
branch
from
34ba89b to
b84bd3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit implements the capability, the second one uses it for core-js.
Fixes #80