-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
local #10
Open
talmiller2
wants to merge
8
commits into
brentp:master
Choose a base branch
from
talmiller2:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
local #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talmiller2
commented
Sep 3, 2020
- Can now run normal non-local (queue) jobs and local jobs (useful for testing, while using the same scripts).
- Added functions that can check status of jobs and kill them (for both local and non-local runs). Useful for example in envelope scripts that need to wait for jobs to finish to continue sending more jobs or post-process.
- Added tests via unittest for the added functionalities.
- Job names now get to keep their underscores (were previously removed).
brentp
reviewed
Sep 3, 2020
if bash_strict: | ||
bash_setup.append("set -eo pipefail -o nounset") | ||
for k, v in sorted(slurm_kwargs.items()): # sort only for the doctest purpose | ||
is_long_option = len(k) > 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with did you remove the --time arugment?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.