Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose all supported signature algorithms list #192

Closed
wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

Follow-up to #187.

I agree to license my contributions to each file under the terms
given at the top of each file I changed.

Follow-up to briansmith#187.

I agree to license my contributions to each file under the terms
given at the top of each file I changed.
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #192 (ad9057d) into main (07306a6) will increase coverage by 0.10%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   71.32%   71.42%   +0.10%     
==========================================
  Files          15       15              
  Lines        1395     1400       +5     
==========================================
+ Hits          995     1000       +5     
  Misses        400      400              
Impacted Files Coverage Δ
src/lib.rs 15.09% <0.00%> (ø)
src/signed_data.rs 100.00% <ø> (ø)
tests/integration.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07306a6...ad9057d. Read the comment docs.

@briansmith
Copy link
Owner

Sorry, I know I asked you specifically to make this change, but now I remember why we don't expose this: In the past, and probably in the future, we've implemented algorithms (e.g. SHA-1-based algorithms) that people probably shouldn't use, and we don't want to encourage people to accidentally enable them. So I'm just going to close this and I'll comment in your other PR.

@briansmith briansmith closed this Feb 17, 2021
@stepancheg
Copy link
Contributor Author

Maybe could be called something like "all modern algorithms", not "all algorithms", but fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants