Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(react-native): patch static fixtures to fix boost download url #2280

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

yousif-bugsnag
Copy link
Contributor

@yousif-bugsnag yousif-bugsnag commented Jan 10, 2025

Goal

Fixes failing RN test fixture builds (RN v0.66-v0.69) that began failing due to an error when installing the boost pod.

It looks like this is a recurrence of an old upstream issue with the jfrog distribution of the boost pod that has been fixed in more recent versions of React Native (see facebook/react-native#42180)

Design

As per the linked issue above, installed patch-package into the affected test fixtures and applied a patch to install boost from the boost archive url rather than jfrog.

Testing

Covered by a full CI run

Copy link

github-actions bot commented Jan 10, 2025

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.89 kB 13.78 kB
After 45.89 kB 13.78 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 5f2ffd7

@yousif-bugsnag yousif-bugsnag marked this pull request as ready for review January 10, 2025 15:18
@yousif-bugsnag yousif-bugsnag merged commit 1e8bb4c into next Jan 10, 2025
134 checks passed
@yousif-bugsnag yousif-bugsnag deleted the rn-fixture-boost-patch branch January 10, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants