Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop custom homebrew tap #379

Merged
merged 1 commit into from
Dec 3, 2023
Merged

Conversation

tisba
Copy link
Contributor

@tisba tisba commented Nov 23, 2023

See #122

As discussed in #122 the custom homebrew tap can probably just be dropped. This is just a suggestion, @cantino :)

I'm not quite sure how Homebrew does updates to bottled Formula these days. mcfly's Formula lives at https://github.com/Homebrew/homebrew-core/blob/master/Formula/m/mcfly.rb. There is brew bump-formula-pr which should probably do most of the work, I haven't used it in a while though (see https://docs.brew.sh/How-To-Open-a-Homebrew-Pull-Request#submit-a-new-version-of-an-existing-formula).

I -think- all you have to do is (with the version replaced obviously):

brew bump-formula-pr --url https://github.com/cantino/mcfly/archive/refs/tags/v0.8.1.tar.gz mcfly

@praveenperera
Copy link
Collaborator

praveenperera commented Nov 29, 2023

@cantino
Copy link
Owner

cantino commented Dec 3, 2023

Thanks @praveenperera, but I'm a little unclear on what I need to do. After having merged this, how do I update homebrew when I do a GitHub release? Just the brew bump-formula-pr command or do we need to integrate a runner somehow too?

@praveenperera
Copy link
Collaborator

@cantino I think we just take out the custom tap and let home-brew make updates. Seems like they update their tap automatically. Homebrew/homebrew-core#147318

And if not we can make a PR in their repo.

@cantino
Copy link
Owner

cantino commented Dec 3, 2023

Okay let's try it.

@cantino
Copy link
Owner

cantino commented Dec 3, 2023

And remove cantino/homebrew-mcfly too?

@cantino cantino merged commit a15d796 into cantino:master Dec 3, 2023
6 of 27 checks passed
@cantino
Copy link
Owner

cantino commented Dec 3, 2023

See revert, I need to think about this and test it a bit more.

@cantino
Copy link
Owner

cantino commented Dec 4, 2023

➜  mcfly git:(master) ✗ brew bump-formula-pr --url https://github.com/cantino/mcfly/archive/refs/tags/v0.8.3.tar.gz mcfly
Error: No available formula with the name "mcfly".
➜  mcfly git:(master) ✗ brew bump-formula-pr --url https://github.com/cantino/mcfly/archive/refs/tags/v0.8.3.tar.gz cantino/mcfly
Error: No available formula with the name "cantino/mcfly".

Ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants