fixing tests (#62)

checkly · Apr 9, 2021 · 7b0bfea · 7b0bfea
1 parent e713bd3
commit 7b0bfea
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -1,8 +1,6 @@
 name: Tests
 
 on:
-  push:
-    branches: 
   pull_request:
 
 jobs:
@@ -35,4 +33,5 @@ jobs:
         TF_VAR_checkly_api_key: ${{ secrets.CHECKLY_API_KEY }}
         CHECKLY_API_KEY: ${{ secrets.CHECKLY_API_KEY }}
         CHECKLY_API_URL: ${{ secrets.CHECKLY_API_URL }}
+        TF_ACC: 1
 
diff --git a/checkly/resource_alert_channel_test.go b/checkly/resource_alert_channel_test.go
@@ -129,7 +129,7 @@ func TestAccFail(t *testing.T) {
 				slack {
 				} 
 			}`,
-			Error: `The argument "url" is required`,
+			Error: `Missing required argument`,
 		},
 		{
 			Config: `resource "checkly_alert_channel" "t1" { 

diff --git a/checkly/resource_check_group_test.go b/checkly/resource_check_group_test.go
@@ -122,11 +122,18 @@ func TestAccCheckGroupInvalid(t *testing.T) {
 			Config:      testCheckGroup_invalid,
 			ExpectError: regexp.MustCompile(`Inappropriate value for attribute "activated"`),
 		},
+		{
+			Config:      testCheckGroup_invalid,
+			ExpectError: regexp.MustCompile(`The argument "concurrency" is required`),
+		},
+		{
+			Config:      testCheckGroup_invalid,
+			ExpectError: regexp.MustCompile(`Missing required argument`),
+		},
 	})
 }
 
 func TestAccCheckGroupBasic(t *testing.T) {
-	return
 	accTestCase(t, []resource.TestStep{
 		{
 			Config: testCheckGroup_basic,
-Original file line number
+Diff line change
@@ Expand Up / @@ -129,7 +129,7 @@ func TestAccFail(t *testing.T) { @@
     				slack {
     				}
     			}`,
-    			Error: `The argument "url" is required`,
+    			Error: `Missing required argument`,
     		},
     		{
     			Config: `resource "checkly_alert_channel" "t1" {
@@ Expand Down @@