Chore/update nim version #1052

2-towns · 2024-12-18T16:46:56Z

Update Nim to ~~2.0.12~~ 2.0.14

2-towns · 2024-12-19T09:05:56Z

codex/rest/json.nim

@@ -90,7 +90,7 @@ proc init*(_: type RestNode, node: dn.Node): RestNode =
    peerId: node.record.data.peerId,
    record: node.record,
    address: node.address,
-    seen: node.seen
+    seen: node.alreadySeen()


@cskiraly Is this the right method to call to verify that a node is seen?

alreadySeen tells you whether it had been already seen (responded) at least once.

seen, instead, gives you a exponential moving average of responses (or missing responses), with more weight on recent attempts.

Okay so if I want to detect the connection with a peer is "good enough", I could check that node.seen > 0.5 I guess ? 0.5 is totally arbitrary.

…e coding fix attempt code

# Conflicts: # codex/contracts/clock.nim # codex/contracts/market.nim # codex/utils/asyncstatemachine.nim # tests/integration/nodeprocess.nim # tests/integration/testecbug.nim # tests/integration/testmarketplace.nim # tests/integration/testproofs.nim

2-towns · 2025-01-07T08:03:28Z

.github/actions/nimbus-build-system/action.yml

+      if: inputs.os == 'windows'
+      shell: ${{ inputs.shell }} {0}
+      run: |
+        git config --global core.symlinks false


@veaceslavdoina Double check if it is okay for you

dryajov · 2025-01-09T00:51:03Z

tests/codex/testchunking.nim

-    expect Defect:
-      await raiseStreamException(newException(CatchableError, "test error"))
+  # This test cannot exist anymore.
+  # The signature of the method readOnce is explicitly listing the error raised:


Cool, I think we can get rid of this test completely.

dryajov · 2025-01-09T00:53:29Z

Great job! This is looking really good, lets try to merge this ASAP

veaceslavdoina · 2025-01-09T14:08:41Z

.github/actions/nimbus-build-system/action.yml

      if: inputs.os == 'windows'
      shell: ${{ inputs.shell }} {0}
      run: |
-        pacman -U --noconfirm https://repo.msys2.org/mingw/ucrt64/mingw-w64-ucrt-x86_64-gcc-13.2.0-6-any.pkg.tar.zst https://repo.msys2.org/mingw/ucrt64/mingw-w64-ucrt-x86_64-gcc-libs-13.2.0-6-any.pkg.tar.zst
+        pacman -U --noconfirm https://repo.msys2.org/mingw/ucrt64/mingw-w64-ucrt-x86_64-gcc-14.2.0-2-any.pkg.tar.zst https://repo.msys2.org/mingw/ucrt64/mingw-w64-ucrt-x86_64-gcc-libs-14.2.0-2-any.pkg.tar.zst


Windows is installing latest GCC version, which currently is 14 and 15 is on the way :)

We can remove this step, but later we might have an issue with version 15 (?).

For Windows 2025 right ?

But the windows-latest is still pointing on windows-2022 which is using gcc 12.

We are not relying on the preinstalled GCC on Windows. It is about MSYS2 and how it works

MSYS2 is a rolling release distribution

At some point, it will just install latest GCC and version 15 will be released in March~April (#875 (comment)). It will appear in MSYS2 repository with a delay and we can expect an issue in August, as we had it with the version 14 😄

So, if we remove that step, we can get in the the issue in August, but will have latest GCC releases all the time.

Let's leave it to have a stable CI?

We are not relying on the preinstalled GCC on Windows. It is about MSYS2 and how it works

Ah ok.

Let's leave it to have a stable CI?

Yeah I agree. I prefer to leave it for now and after testing GCC 15, we could remove it.

veaceslavdoina · 2025-01-09T14:20:32Z

.github/workflows/ci-reusable.yml

@@ -40,6 +40,7 @@ jobs:
          os: ${{ matrix.os }}
          shell: ${{ matrix.shell }}
          nim_version: ${{ matrix.nim_version }}
+          coverage: false


We should add an input coverage to the .github/actions/nimbus-build-system/action.yml and set it false by default, than pass true just for coverage (we are doing it already).

https://github.com/codex-storage/nim-codex/actions/runs/12689785802

veaceslavdoina · 2025-01-09T14:27:27Z

.github/workflows/ci.yml

-            os {linux},   cpu {amd64}, builder {ubuntu-20.04},   tests {contract},    nim_version {${{ env.nim_version }}}, shell {bash --noprofile --norc -e -o pipefail}
-            os {linux},   cpu {amd64}, builder {ubuntu-20.04},   tests {integration}, nim_version {${{ env.nim_version }}}, shell {bash --noprofile --norc -e -o pipefail}
-            os {linux},   cpu {amd64}, builder {ubuntu-20.04},   tests {tools},       nim_version {${{ env.nim_version }}}, shell {bash --noprofile --norc -e -o pipefail}
+            os {linux},   cpu {amd64}, builder {ubuntu-latest},   tests {unittest},    nim_version {${{ env.nim_version }}}, shell {bash --noprofile --norc -e -o pipefail}


We switched to ubuntu-20.04 in #939 and because of the #932.

Probably we should stick with the 20.04?

Btw, we also have a release workflow and 20.04 is required mostly for releases. But as I remember, there can be an issue when cache from latest (24.04) is restored on 20.04 and vice versa.

Probably we should stick with the 20.04?

There are two problems: 1- 20.04 will be deprecated soon, 2- I am not sure I will be able to install GCC 14 on ubuntu 20.04.

Maybe #932 is fixed now with the update to Nim 2.

It was related to the glibc version. So, new releases will not run on old distributions.

The Ubuntu 20.04 Actions runner image will begin deprecation on 2025-02-01 and will be fully unsupported by 2025-04-01 #11101

Deprecation will begin on 2025-02-01 and the image will be fully unsupported by 2025-04-01.

The Ubuntu lifecycle and release cadence

Yes, this is what we discussed yesterday.

benbierens · 2025-01-09T15:47:58Z

Running make clean, make update, and make, works without any issues on my Win11 MSYS2-UCRT.
Commit 801f6b7 - Disable CI cache for coverage.
Make test also builds, and passes.

# Conflicts: # codex/node.nim # tests/codex/node/testcontracts.nim # vendor/nim-ethers

# Conflicts: # codex.nim # codex/conf.nim # codex/discovery.nim # tests/codex/slots/testbackendfactory.nim # tests/codex/slots/testprover.nim # tests/contracts/testDeployment.nim # vendor/nim-ethers

2-towns added 15 commits November 28, 2024 09:47

Move to version 2.0.6

b5af96f

Update nim-confutils submodule to latest version

ca2b63c

Update dependencies

ef3274b

Update Nim version to 2.0.12

34f5e00

Add gcsafe pragma

7c9b607

Add missing import

0e00f0c

Update specific conf for Nim 2.x

0ecf3f7

Fix method signatures

4935494

Revert erasure coding attempt to fix bug

a1c8c94

More gcsafe pragma

599e868

Duplicate code from libp2p because it is not exported anymore

a2f0528

Fix camelcase function names

a2f09b2

Use alreadySeen because need is not a bool anymore

902c6dc

newLPStreamReadError does not exist anymore so use another error

83b4943

Replace ValidIpAddress by IpAddress

daadffe

2-towns commented Dec 19, 2024

View reviewed changes

2-towns added 14 commits December 26, 2024 07:14

Add gcsafe pragma

d6b1781

Restore maintenance parameter deleted by mistake when removing esasur…

0724d7f

…e coding fix attempt code

Update method signatures

6ad496d

Copy LPStreamReadError code from libp2p which was removed

5c80a84

Fix camel case

6b64c25

Fix enums in tests

627e6ae

Fix camel case

51a4054

Extract node components to a variable to make Nim 2 happy

ab39da8

Update the tests using ValidIpAddress to IpAddress

3f9f421

Fix cast for value which is already an option

d2388a3

Set nim version to 2.0.x for CI

d9eca3b

Set nim version to 2.0.x for CI

696f66d

Move to miniupnp version 2.2.4 to avoid symlink error

56d2186

2-towns commented Jan 7, 2025

View reviewed changes

2-towns added 2 commits January 7, 2025 15:10

Update to Nim 2.0.14

7bdbd87

Update CI nim versions to 2.0.14

dfcdac6

2-towns marked this pull request as ready for review January 8, 2025 10:46

2-towns added 3 commits January 8, 2025 14:02

Try with GCC 14

f24d264

Replace apt-fast by apt-get

fdba4e7

Update ubuntu runner to latest

251d286

dryajov reviewed Jan 9, 2025

View reviewed changes

dryajov approved these changes Jan 9, 2025

View reviewed changes

2-towns added 2 commits January 9, 2025 12:58

Use Ubuntu 20.04 for coverage

b5848da

Disable CI cache for coverage

801f6b7

veaceslavdoina reviewed Jan 9, 2025

View reviewed changes

2-towns added 10 commits January 9, 2025 17:12

Add coverage property description

2c436db

Remove commented test

958df72

Check the node value of seen instead of using alreadySeen

08ced59

Merge branch 'master' into chore/update-nim-version

00e3f0e

# Conflicts: # codex/node.nim # tests/codex/node/testcontracts.nim # vendor/nim-ethers

Fix the merge. The taskpool work was reverted.

10bc903

Update nim-ethers submodule

66d1c5b

Merge branch 'master' into chore/update-nim-version

943ca8a

# Conflicts: # codex.nim # codex/conf.nim # codex/discovery.nim # tests/codex/slots/testbackendfactory.nim # tests/codex/slots/testprover.nim # tests/contracts/testDeployment.nim # vendor/nim-ethers

Remove deprecated ValidIpAddress. Fix missing case and imports.

fb14b60

Fix a weird issue where nim-confutils cannot find NatAny

5cbb43b

Fix tests and remove useless static keyword

0d71b0a

2-towns added this pull request to the merge queue Jan 10, 2025

Merged via the queue into master with commit f25c555 Jan 10, 2025
17 checks passed

2-towns deleted the chore/update-nim-version branch January 10, 2025 15:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Chore/update nim version #1052

Chore/update nim version #1052

2-towns commented Dec 18, 2024 •

edited

Loading

2-towns Dec 19, 2024

cskiraly Jan 10, 2025

2-towns Jan 10, 2025

2-towns Jan 7, 2025

dryajov Jan 9, 2025

dryajov commented Jan 9, 2025

veaceslavdoina Jan 9, 2025

2-towns Jan 9, 2025

veaceslavdoina Jan 9, 2025 •

edited

Loading

2-towns Jan 9, 2025

veaceslavdoina Jan 9, 2025

veaceslavdoina Jan 9, 2025

2-towns Jan 9, 2025

veaceslavdoina Jan 9, 2025

2-towns Jan 10, 2025

benbierens commented Jan 9, 2025 •

edited

Loading

Chore/update nim version #1052

Chore/update nim version #1052

Conversation

2-towns commented Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dryajov commented Jan 9, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

veaceslavdoina Jan 9, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benbierens commented Jan 9, 2025 • edited Loading

2-towns commented Dec 18, 2024 •

edited

Loading

veaceslavdoina Jan 9, 2025 •

edited

Loading

benbierens commented Jan 9, 2025 •

edited

Loading