-
-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Script: Mailrise (SMTP Gateway) #1340
Conversation
Script validation❌ We found issues in the following changed files: Not executable:
Copyright header line missing or invalid:
Author header line missing or invalid:
License header line missing or invalid:
Source header line missing or invalid:
Script formatting❌ We found issues in the formatting of the following changed files: diff ct/mailrise.sh.orig ct/mailrise.sh
--- ct/mailrise.sh.orig
+++ ct/mailrise.sh
@@ -25,18 +25,18 @@
catch_errors
function update_script() {
- header_info
- check_container_storage
- check_container_resources
- if [[ ! -f /usr/local/bin/mailrise ]]; then
- msg_error "No ${APP} Installation Found!"
- exit
- fi
- msg_info "Updating ${APP} LXC"
- pip3 install mailrise --upgrade &>/dev/null
- systemctl restart mailrise.service
- msg_ok "Updated Successfully"
+ header_info
+ check_container_storage
+ check_container_resources
+ if [[ ! -f /usr/local/bin/mailrise ]]; then
+ msg_error "No ${APP} Installation Found!"
exit
+ fi
+ msg_info "Updating ${APP} LXC"
+ pip3 install mailrise --upgrade &>/dev/null
+ systemctl restart mailrise.service
+ msg_ok "Updated Successfully"
+ exit
}
start
diff install/mailrise-install.sh.orig install/mailrise-install.sh
--- install/mailrise-install.sh.orig
+++ install/mailrise-install.sh
@@ -5,7 +5,7 @@
# License: MIT
# https://github.com/community-scripts/ProxmoxVE/raw/main/LICENSE
-source /dev/stdin <<< "$FUNCTIONS_FILE_PATH"
+source /dev/stdin <<<"$FUNCTIONS_FILE_PATH"
color
verb_ip6
catch_errors |
updated copyright/author
Co-authored-by: Michel Roegl-Brunner <[email protected]>
Co-authored-by: Michel Roegl-Brunner <[email protected]>
corrected copyright/author/license, added source
Added link to discussion/guide
Is this worth to add? 1 year no commit |
Oh i did not check that before. You might be right here. |
Any Feedback? Or we close this tomorrow |
Closing due to lack of response. Please feel free to reopen or create a new PR if needed. @choehn86 |
✍️ Description
This pull request is for a new script to establish a Mailrise LXC (https://github.com/YoRyan/mailrise/), an SMTP gateway for Apprise notifications.
🛠️ Type of Change
Please check the relevant options:
✅ Prerequisites
The following steps must be completed for the pull request to be considered:
📋 Additional Information (optional)
This is my first script contribution and first pull request, open to any critiques or suggestions (even if it's not ultimately accepted for merging)