-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: lint incorrect distro names in os_version
#2155
Conversation
729b45a
to
efb395f
Compare
Why do you need the other PR for this PR? Shouldn't your last commit work on its own? |
I thought so too, but I've tested it, and it has no effect (which is why I ended up opening #2152) |
Although, now with the discussions about the JSON schema etc. - perhaps I'm missing whatever the equivalent of efb395f is on the JSON side? 🤔 |
efb395f
to
93dd085
Compare
using `python conda_smithy/schema.py`
1c2b6ee
to
bd61f01
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit.
This is for linting wrong distro values used in
os_version
(which becomes more important after conda-forge/conda-forge-pinning-feedstock#6626, as it might lead to zipping problems and thus rerender errors).With this PR, a
conda-forge.yml
ofwould lead to
We'll certainly want to polish this further (e.g. into a concrete hint/lint), hence this is a draft. It's also a draft because by themselves, the changes in dc74f55 do not work. It needs #1920 (or something similar) to actually work, see #2152. Currently it includes that PR, which should be merged first.