Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch Migrator #11

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This feedstock is being rebuilt as part of the aarch64/ppc64le migration.

Feel free to merge the PR if CI is all green, but please don't close it
without reaching out the the ARM migrators first at @conda-forge/arm-arch.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/2818616271, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@msarahan msarahan force-pushed the bot-pr_arch_h5a61c9 branch from 21fda6d to 85b1848 Compare September 6, 2022 21:34
@msarahan
Copy link
Member

msarahan commented Sep 7, 2022

@isuruf thanks for the commit. I think ultimately we'll hit the issue of the JS runtime snapshot, as detailed in denoland/deno#1846.

I'm working on that separately, such that the snapshot is more optional and can be generated on the fly on user systems.

declare -x "CARGO_TARGET_${CONDA_RUST_HOST}_RUSTFLAGS"="-C link-arg=-Wl,-rpath,${BUILD_PREFIX}/lib,-L${BUILD_PREFIX}/lib"
declare -x "CARGO_TARGET_${CONDA_RUST_TARGET}_RUSTFLAGS"="-C link-arg=-Wl,-rpath,${PREFIX}/lib,-L${PREFIX}/lib"
declare -x "CFLAGS_${CONDA_RUST_HOST}_RUSTFLAGS"="-Wl,-rpath,${BUILD_PREFIX}/lib -L${BUILD_PREFIX}/lib"
declare -x "CFLAGS_${CONDA_RUST_TARGET}_RUSTFLAGS"="-Wl,-rpath,${PREFIX}/lib octave-feedstock/pull/81/files-L${PREFIX}/lib"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's going on here? bad copy-paste?

@mdekstrand
Copy link
Contributor

I have the aarch64 cross-build all working in #68 (with a patch to Deno to clean up a few build issues — will be looking at getting that upstreamed).

@mdekstrand
Copy link
Contributor

Since aarch64 cross-build is now working, do we still need this PR? If we do still want PPC64LE, I expect we would want to start from the current feedstock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants