danger-kotlin cannot compile on Xcode 15+ #286
Conversation
mrbass21
force-pushed
the
xcode15KotlinUpdate
branch
from
82fd47f to
58f4b53
Compare
|
@mrbass21 Hey mate, thanks for the contribution! However, that does not make sense to upgrade kotlin to that version because the latest is higher (check on kotlin website), I'll be happy to merge this PR if you can update it. |
|
Just letting you know I'm working on this. I'm not an Android or Kotlin developer and the builds break when Kotlin is updated. I'm seeing if I can fix them. Edit: I found that I could get to 2.0.10 without any build issues. Going to 2.0.20 causes the library to have compilation issues. I will keep working at it, but if 2.0.10 is acceptable to get compiles working under Xcode 15+, and someone else (who actually knows the tooling better) can update to the latest Kotlin, feel free to accept as is. Thanks! Edit 2: Was able to get it working with the latest version of Kotlin, but it required updating JDK to 17, and upgrading Gradle to 8, and changing the source for shadowjar to com.gradleup. If those changes push this out of scope, this can go in as is. Getting the project to compile with Kotlin 2.0.20+ was entirely solved by @DavidBrunow, should this work be used. Will check for feedback. Thank you! |
mrbass21
force-pushed
the
xcode15KotlinUpdate
branch
from
58f4b53 to
72eb681
Compare
|
@mrbass21 I think you're a Kotlin dev now. You got through a major Gradle and JVM upgrade in one PR. 😄 |
Not qualified yet! This one only has a Kotlin bump. We'll have to delay the celebration 😝 |
|
Gradle and Kotlin versions has been updated #251 with pipeline fixing. Could you please check with the latest master branch please? |
Was able to build from main with Xcode 16 and macOS 15.0.1. |
danger-kotlin will not compile on native mac using Xcode 15+. This seems to be due to Kotlin. Kotlin seems to have resolved this in version 1.9.10.
I don't know Kotlin tooling that well, so please let me know if I've missed anything in this PR that needs to be addressed. I was able to run the gradlew commands in the make file and all of them build successfully.
Thanks!