chore: support deno 2.0 by replacing __dirname -> import.meta.dirname. #5
Conversation
|
Tests keep failing because of On further investigation it's crashing while trying to print why it crashed... Real error is |
|
Strange, and you get the same error locally when running the tests? Seems like the built code is somehow wrong. |
|
Getting it locally as well yeah. I'm gonna give it a shot on a Linux machine see if it makes a difference. Also another idea.. do you know where the build code originally came from? Maybe there's an updated version? |
|
Tried running the tests on deno 1.x and it worked. I guess the js build files don't work in deno 2.x. Need to figure out how to update them. There wouldn't happen to be a un-uglified version of the sodium.js build file somewhere? |
|
Looks like the files came from here originally https://github.com/jedisct1/libsodium.js. I'll try and update them and see what happens. |
|
Have you tried using libsodiumjs (or even the web standard crypto if that fits your needs) directly? It may be easier to depend on it than this, honeslty ill-maintained wrapper module. |
|
I hadn't heard of I don't mind continuing to work on this if no one else is gonna do it. It's an excuse to learn something on my end. |
Well, if you are doing anything requiring libsodium and crypto, I would hope the user thinks long and hard about the problem theyre trying to solve if it has anything to do with authentication, signing, etc. But I get the need for basic access to cryptographic functions when for example interacting with an API.
Go for it! I would appreciate it! |
mash8
force-pushed
the
support-deno-2.0
branch
from
43fa998 to
5820870
Compare
- support deno 2.0 by replacing __dirname -> import.meta.dirname. - Replaced https://github.com/denolib/setup-deno?tab=readme-ov-file github action with https://github.com/denoland/setup-deno since the former is depreciated. - Removed a bunch of redundant files. - Added tests for sumo sodium - crypto_pwhash & crypto_pwhash_str no longer exited in the non sumo version so moved the typing (there may be more method that are missing).
mash8
force-pushed
the
support-deno-2.0
branch
from
5820870 to
ee01744
Compare
There was a problem hiding this comment.
Having the sub repo was redundant so I removed it. Along with a bunch of other files.
| @@ -657,31 +657,6 @@ export interface Sodium { | |||
| outputFormat: StringOutputFormat, | |||
| ): StringCryptoKX; | |||
|
|
|||
| crypto_pwhash( | |||
There was a problem hiding this comment.
So these two method no longer existed on the non sumo sodium for some reason. I only caught this because of the tests. Not sure what else could of been impacted.
I moved these methods to the SumoAddons type since it exists there.
There was a problem hiding this comment.
Got the new version of the file from the sodiumjs repo and patched it up to work with deno.
Also it's no longer minified. Didn't see a reason that it needed to be. Was making it hard to work with...
|
Btw @eliassjogreen I noticed you're also apart of the https://github.com/denosaurs/opus repo. I created a fix for that repo here denosaurs/opus#3. It's a lot simpler than this... |
For this issue #4