Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra supplied "--" in AddNpmApp with args #7159

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

matthebrown
Copy link
Contributor

@matthebrown matthebrown commented Jan 20, 2025

Description

Removes the extra '--' in the AddNpmApp method when args are supplied.

Fixes #5934

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 20, 2025
@matthebrown matthebrown changed the title Remove extra supplied '--' in AddNpmApp with args Remove extra supplied "--" in AddNpmApp with args Jan 20, 2025
@davidfowl
Copy link
Member

Tests for what failed before to make sure it doesn't fail now?

@matthebrown
Copy link
Contributor Author

Tests for what failed before to make sure it doesn't fail now?

Added test case in latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AddNpmApp with args supplied as extra "--" i.e. [ "run", "dev", "--", "--port 12345", "--strictPort" ]
2 participants