Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for methods with multiple JSInvokable attributes #59787

Conversation

rsandbach
Copy link
Contributor

Improve support for methods with multiple JSInvokable attributes

Change ScanAssemblyForCallableMethods and ScanTypeForCallableMethods to call GetCustomAttribute_s_ instead of GetCustomAttribute. Add all the defined identifiers as opposed to crashing on an unhandled AmbiguousMatchException.

Description

Fixes #54646

@rsandbach rsandbach requested a review from a team as a code owner January 9, 2025 05:12
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Jan 9, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 9, 2025
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 16, 2025
@javiercn
Copy link
Member

/azp run aspnetcore-ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@javiercn javiercn removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Jan 20, 2025
@lewing
Copy link
Member

lewing commented Jan 22, 2025

Thank you for resolving this!

@lewing lewing merged commit df7b408 into dotnet:main Jan 22, 2025
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSInvokableAttribute - No details on where the issue is. Undebuggable.
3 participants