[Android] Fix for WebView Fails to Load URLs with Certain Encoded Characters #27003
+81
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @praveenkumarkarunanithi! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree company="Syncfusion, Inc." |
vishnumenon2684
added
the
partner/syncfusion
MartyIX
reviewed
Jan 8, 2025
| @@ -32,7 +32,7 @@ void IWebViewDelegate.LoadUrl(string? url) | |||
| _handler.CurrentNavigationEvent = WebNavigationEvent.NewPage; | |||
| } | |||
|
|
|||
| if (url != null && !url.StartsWith('/') && !Uri.IsWellFormedUriString(url, UriKind.Absolute)) | |||
| if (url != null && !url.StartsWith('/') && !Uri.TryCreate(url, UriKind.Absolute, out _)) | |||
There was a problem hiding this comment.
Should this change be tested by a unit test? One can extract a method and test it with https://github.com/SuthiYuvaraj/maui/blob/390e4cd1c5eed59ecaf1fcd37975e7f6f5422d6d/src/Controls/tests/TestCases.HostApp/Resources/Raw/01-A%C4%9F-Sistem%20Bilgi%20G%C3%BCvenli%C4%9Fi%20Md/dotnet%20maui.pdf input. That would be faster and one can test more inputs as well.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The root cause of the issue is the use of
Uri.IsWellFormedUriStringfor validating URLs in the WebView control. This method applies overly strict checks, including theIsWellFormedOriginalStringtest, which can incorrectly reject valid URLs, especially those containing encoded characters or international characters. This leads to improper handling of certain valid URLs, causing them to be treated as relative paths instead of absolute URLs.Description of Change
In the WebView control, the URL validation logic in
MauiWebView.LoadUrlhas been updated to replaceUri.IsWellFormedUriStringwithUri.TryCreate. This change ensures that a wider range of valid URLs, including those with encoded and international characters, are correctly handled as absolute URLs.Issues Fixed
Fixes #26843
Fixes #23767
Fixes #23690
Tested the behaviour in the following platforms
Screenshots