Enable nullability in DesignerActionMethodItem #12676
Conversation
gpetrou
force-pushed
the
DesignerActionMethodItem
branch
from
909d588 to
e03833e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12676 +/- ##
===================================================
+ Coverage 76.03108% 76.03455% +0.00346%
===================================================
Files 3181 3181
Lines 639670 639700 +30
Branches 47215 47215
===================================================
+ Hits 486348 486393 +45
+ Misses 149805 149788 -17
- Partials 3517 3519 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
|
||
| public virtual bool IncludeAsDesignerVerb { get; } | ||
|
|
||
| public virtual void Invoke() | ||
| { | ||
| _methodInfo ??= _actionList?.GetType()?.GetMethod(MemberName, BindingFlags.Default | BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic); | ||
| _methodInfo ??= _actionList?.GetType()?.GetMethod(MemberName!, BindingFlags.Default | BindingFlags.Instance | BindingFlags.Public | BindingFlags.NonPublic); |
There was a problem hiding this comment.
Please add a comment explaining in detail why MemberName! can never be null.
There was a problem hiding this comment.
This can actually be null, but I did not want to add an extra exception to it.
@lonitra should I throw an exception instead?
There was a problem hiding this comment.
It's appropriate to add a more descriptive exception in this case. InvalidOperationException with message "Could not find method '{0}'."
Tanya-Solyanik
added
the
waiting-author-feedback
dotnet-policy-service
bot
removed
the
waiting-author-feedback
LeafShi1
added
the
waiting-review
There was a problem hiding this comment.
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/System.Windows.Forms.Design/src/PublicAPI.Shipped.txt: Language not supported
Tanya-Solyanik
added
waiting-author-feedback
Proposed changes
Microsoft Reviewers: Open in CodeFlow