fix(menu-button): added direct selector for icons (#2425)

eBay · Aug 20, 2024 · 9178aae · 9178aae
1 parent f64118e
commit 9178aae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/dist/menu-button/menu-button.css b/dist/menu-button/menu-button.css
@@ -109,8 +109,8 @@ div.menu-button__item[role^="menuitem"]:last-child {
     );
 }
 
-.fake-menu-button__item svg.icon--16,
-.menu-button__item svg.icon--16 {
+.fake-menu-button__item > svg.icon--16,
+.menu-button__item > svg.icon--16 {
     align-self: center;
     fill: currentColor;
     margin: 0 auto;
@@ -119,8 +119,8 @@ div.menu-button__item[role^="menuitem"]:last-child {
     stroke-width: 0;
 }
 
-.fake-menu-button__item svg.icon--16:last-child,
-.menu-button__item svg.icon--16:last-child {
+.fake-menu-button__item > svg.icon--16:last-child,
+.menu-button__item > svg.icon--16:last-child {
     margin-left: var(--spacing-100);
 }
 a.fake-menu-button__item {

diff --git a/src/sass/menu-button/menu-button.scss b/src/sass/menu-button/menu-button.scss
@@ -42,13 +42,13 @@ div.menu-button__item[role^="menuitem"] {
     cursor: default; /* needed to override text cursor */
 }
 
-.menu-button__item svg.icon--16,
-.fake-menu-button__item svg.icon--16 {
+.menu-button__item > svg.icon--16,
+.fake-menu-button__item > svg.icon--16 {
     @include menu-menuitem-status();
 }
 
-.menu-button__item svg.icon--16:last-child,
-.fake-menu-button__item svg.icon--16:last-child {
+.menu-button__item > svg.icon--16:last-child,
+.fake-menu-button__item > svg.icon--16:last-child {
     margin-left: var(--spacing-100);
 }