Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fake-button): updated disabled styles #2413

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix(fake-button): updated disabled styles #2413

merged 2 commits into from
Aug 21, 2024

Conversation

saiponnada
Copy link
Contributor

@saiponnada saiponnada commented Aug 8, 2024

Fixes #2387

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Updated the disabled styles to make fake button look disabled

Screenshots

image image

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue
  • I regenerated all CSS files under dist folder
  • I tested the UI in all supported browsers
  • I did a visual regression check of the components impacted by doing a Percy build and approved the build
  • I tested the UI in dark mode and RTL mode
  • I added/updated/removed Storybook coverage as appropriate

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 07e1adc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saiponnada saiponnada self-assigned this Aug 13, 2024
@saiponnada saiponnada marked this pull request as ready for review August 21, 2024 19:27
@saiponnada saiponnada merged commit da48437 into 18.2.0 Aug 21, 2024
1 check failed
This was referenced Aug 27, 2024
@saiponnada saiponnada deleted the fake-btn branch September 10, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants