chore: remove deprecated code for next major #2536
Conversation
🦋 Changeset detectedLatest commit: fc79149 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| // Deprecated, remove next major | ||
| // This is tied with handle, once we remove handle this needs to be removed | ||
| .lightbox-dialog__window--expanded { | ||
| height: 95%; |
There was a problem hiding this comment.
Is this accompanied by a change so that the dialog is essentially always in this expanded state? Even if we do that, I'm not convinced that every dialog should be almost fullscreen
There was a problem hiding this comment.
Agree. We need sensible defaults for our major breakpoints. Almost fullscreen would not be a sensible default for large screens. Design system should have defaults those specified. But also we probably need the capacity for apps to fine tune those when needed (using component level CSS variables?)
There was a problem hiding this comment.
I removed the modifier which expanded the dialog to be expanded to almost full screen when the handle is clicked. Not sure what this comment is trying to say. The default is normal size
Went through the code and removed all deprecated code.
Please verify these are okay to remove. If there are additional ones (like fullscreen or drawer dialog), will add them too!
Things I did not change because I was not sure if its okay to remove, but happy to remove:
https://github.com/eBay/skin/blob/master/src/sass/page-grid/page-grid.scss#L57-L63 subgrid
https://github.com/eBay/skin/blob/master/src/sass/variables/_variables.scss#L30 variables (both because it might add too many breaking changes if we add dialogs on top of it, but also which ones need to be removed?)