Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default modules config path on debian based systems #12

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

wsmirnow
Copy link
Contributor

@wsmirnow wsmirnow commented Jan 8, 2025

Default Nginx modules configuration path is /etc/nginx/modules-enabled/ on debian based systems. All *.conf files there are linked to /usr/share/nginx/modules-available/. We should respect this in the nginx configuration.

root@3a4203d78897:/# ls -la /etc/nginx/modules-enabled/
total 20
drwxr-xr-x. 2 root root 4096 Jan  8 17:05 .
drwxr-xr-x. 8 root root 4096 Jan  8 17:03 ..
lrwxrwxrwx. 1 root root   57 Jan  8 17:05 50-mod-http-auth-pam.conf -> /usr/share/nginx/modules-available/mod-http-auth-pam.conf
lrwxrwxrwx. 1 root root   56 Jan  8 17:05 50-mod-http-dav-ext.conf -> /usr/share/nginx/modules-available/mod-http-dav-ext.conf
lrwxrwxrwx. 1 root root   53 Jan  8 17:05 50-mod-http-echo.conf -> /usr/share/nginx/modules-available/mod-http-echo.conf
lrwxrwxrwx. 1 root root   55 Jan  8 17:05 50-mod-http-geoip2.conf -> /usr/share/nginx/modules-available/mod-http-geoip2.conf
lrwxrwxrwx. 1 root root   60 Jan  8 17:05 50-mod-http-subs-filter.conf -> /usr/share/nginx/modules-available/mod-http-subs-filter.conf
lrwxrwxrwx. 1 root root   62 Jan  8 17:05 50-mod-http-upstream-fair.conf -> /usr/share/nginx/modules-available/mod-http-upstream-fair.conf
lrwxrwxrwx. 1 root root   50 Jan  8 17:03 50-mod-stream.conf -> /usr/share/nginx/modules-available/mod-stream.conf
lrwxrwxrwx. 1 root root   57 Jan  8 17:05 70-mod-stream-geoip2.conf -> /usr/share/nginx/modules-available/mod-stream-geoip2.conf

Default Nginx modules configuration path is /etc/nginx/modules-enabled/ on debian based systems. All *.conf files there are linked to /usr/share/nginx/modules-available/. We should respect this in the nginx configuration.

```
root@3a4203d78897:/# ls -la /etc/nginx/modules-enabled/
total 20
drwxr-xr-x. 2 root root 4096 Jan  8 17:05 .
drwxr-xr-x. 8 root root 4096 Jan  8 17:03 ..
lrwxrwxrwx. 1 root root   57 Jan  8 17:05 50-mod-http-auth-pam.conf -> /usr/share/nginx/modules-available/mod-http-auth-pam.conf
lrwxrwxrwx. 1 root root   56 Jan  8 17:05 50-mod-http-dav-ext.conf -> /usr/share/nginx/modules-available/mod-http-dav-ext.conf
lrwxrwxrwx. 1 root root   53 Jan  8 17:05 50-mod-http-echo.conf -> /usr/share/nginx/modules-available/mod-http-echo.conf
lrwxrwxrwx. 1 root root   55 Jan  8 17:05 50-mod-http-geoip2.conf -> /usr/share/nginx/modules-available/mod-http-geoip2.conf
lrwxrwxrwx. 1 root root   60 Jan  8 17:05 50-mod-http-subs-filter.conf -> /usr/share/nginx/modules-available/mod-http-subs-filter.conf
lrwxrwxrwx. 1 root root   62 Jan  8 17:05 50-mod-http-upstream-fair.conf -> /usr/share/nginx/modules-available/mod-http-upstream-fair.conf
lrwxrwxrwx. 1 root root   50 Jan  8 17:03 50-mod-stream.conf -> /usr/share/nginx/modules-available/mod-stream.conf
lrwxrwxrwx. 1 root root   57 Jan  8 17:05 70-mod-stream-geoip2.conf -> /usr/share/nginx/modules-available/mod-stream-geoip2.conf
```
Copy link
Contributor

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable but cannot verify right now.

@lkiesow lkiesow merged commit 6ea76de into main Jan 9, 2025
2 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants