Disable emmalloc_trim #23344
Merged
Disable emmalloc_trim #23344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this function has no been working correctly since emscripten-core#13442 when sbrk stopped accepting negative values. Maybe we can find a way to bring this functionality back but disabling it for now seems safest. See: emscripten-core#23343
|
Since its been broken for ~4 years I guess nobody is using it ? |
|
This is why it would have been good to have #23330 all along. If we had that landed 4 years ago this breakage would have happened since that assert would have fired. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this function has not been working correctly since #13442 when sbrk stopped accepting negative values.
Maybe we can find a way to bring this functionality back but disabling it for now seems safest.
See: #23343