feat(default-memory-limits): set default memory limits #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s " (envoyproxy#4979)" This reverts commit c6d5a54.
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
ryanhristovski
force-pushed
the
revert-4979-revert-4960-feat-set-default-memory-limits
branch
from
93b5fbb to
79c5920
Compare
|
Not sure why DCO is failing here, but PR is ready |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5032 +/- ##
==========================================
- Coverage 66.74% 66.74% -0.01%
==========================================
Files 209 209
Lines 32366 32369 +3
==========================================
Hits 21604 21604
- Misses 9456 9458 +2
- Partials 1306 1307 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4979 and removes the shutdown manager configuration for now.
The issue for failed CI was shutdown-manager oomkilling. While I do some benchmarking on this service to determine what a good memory limit will be using this comment as a starting point #4960 (comment). I am going to go ahead and continue with the default memory limits.
Original PR: #4960