Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SerializableSecret for &Secret<T> #61

Merged
merged 1 commit into from
May 11, 2024
Merged

Implement SerializableSecret for &Secret<T> #61

merged 1 commit into from
May 11, 2024

Conversation

LukeMathWalker
Copy link
Contributor

No description provided.

@LukeMathWalker LukeMathWalker marked this pull request as draft April 22, 2024 09:43
@eopb eopb marked this pull request as ready for review May 11, 2024 09:04
eopb
eopb approved these changes May 11, 2024
View reviewed changes
Copy link
Owner

@eopb eopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR Luca 👋

I'll merge and fix the tiny issue preventing it from compiling

@eopb eopb merged commit 3e9c3f6 into eopb:main May 11, 2024
1 of 6 checks passed
eopb added a commit that referenced this pull request May 11, 2024
@eopb
fix: compilation failure with serde feature
e9da726 
Introduced in #61
@eopb eopb mentioned this pull request May 11, 2024
Merged
@LukeMathWalker LukeMathWalker deleted the patch-1 branch May 11, 2024 14:24
@LukeMathWalker
Copy link
Contributor Author

Thank you! I was looking for time to come back to it 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eopb eopb eopb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeMathWalker @eopb