Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Convert whole project to a React App #3

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Refactor: Convert whole project to a React App #3

merged 2 commits into from
Jun 14, 2023

Conversation

firasrg
Copy link
Owner

@firasrg firasrg commented Jun 14, 2023

As mentioned in #1 This is just a first stable version!

What's Good?

  1. No Maven, Gradle or Java files anymore, It's a React App project now;
  2. Using ReactJS v18.
  3. Using Vite for autoconfiguration and dev env setup (Create React App is no more);
  4. Using static analysis with Typescript, ESlint and Prettier;
  5. Using modern routing with React Router.

What's Not Good?

  1. We've been forced to use Less and Bootstrap to make the first component render as expected.
  2. There are some missing types declarations (Currently investgating)

What's Next?

I've started by creating an issue to set up repository files (readme, guidelines, etc..) before opening any more issues.

Next, I think to apply changes carefully and step by step in order to reach the final and optimal app.

firasrg added 2 commits June 13, 2023 23:11
Comments:
1. empowering code style with eslint-config-universe and prettier;
2. use modern routing with react-router-dom;
3. remove unused files;
4. Fix layouts, icons and styles
@firasrg firasrg linked an issue Jun 14, 2023 that may be closed by this pull request
@firasrg firasrg removed a link to an issue Jun 14, 2023
@firasrg firasrg linked an issue Jun 14, 2023 that may be closed by this pull request
@firasrg firasrg merged commit 72c58f9 into master Jun 14, 2023
@firasrg firasrg deleted the refactor branch July 5, 2023 19:45
firasrg pushed a commit that referenced this pull request Sep 21, 2024
…ot-v3

resolves #3 Upgrade to latest spring-petclinic/spring-petclinic-rest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring 🚧
1 participant