Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ramips-mt7621: add tp-link ax23 #3432

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

maurerle
Copy link
Member

@maurerle maurerle commented Jan 22, 2025

  • Must be flashable from vendor firmware
    • Web interface
    • TFTP
    • Other:
  • Must support upgrade mechanism
    • Must have working sysupgrade
      • Must keep/forget configuration (sysupgrade [-n], firstboot)
    • Gluon profile name matches autoupdater image name
      (lua -e 'print(require("platform_info").get_image_name())') tp-link-archer-ax23-v1
  • Reset/WPS/... button must return device into config mode
  • Primary MAC address should match address on device label (or packaging)
    (https://gluon.readthedocs.io/en/latest/dev/hardware.html#hardware-support-in-packages)
    • When re-adding a device that was supported by an earlier version of Gluon, a
      factory reset must be performed before checking the primary MAC address, as
      the setting from the old version is not reset otherwise.
  • Wired network
    • should support all network ports on the device
    • must have correct port assignment (WAN/LAN)
      • if there are multiple ports but no WAN port:
        • the PoE input should be WAN, all other ports LAN
        • otherwise the first port should be declared as WAN, all other ports LAN
  • Wireless network (if applicable)
    • Association with AP must be possible on all radios
    • Association with 802.11s mesh must work on all radios
    • AP+mesh mode must work in parallel on all radios
  • LED mapping
    • Power/system LED
    • Radio LEDs
      • Should map to their respective radio
      • Should show activity
    • Switch port LEDs
      • Should map to their respective port (or switch, if only one led present)
      • Should show link state and activity
  • Outdoor devices only:
    • Added board name to is_outdoor_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
  • Cellular devices only:
    • Added board name to is_cellular_device function in package/gluon-core/luasrc/usr/lib/lua/gluon/platform.lua
    • Added board name with modem setup function setup_ncm_qmi to package/gluon-core/luasrc/lib/gluon/upgrade/250-cellular
  • Docs:
    • Added Device to docs/user/supported_devices.rst

the WPS/Wi-Fi button turns off the wifi. The reset button brings the device into config mode
Looks fine to me.
closes #3257

@github-actions github-actions bot added 3. topic: docs Topic: Documentation 3. topic: hardware Topic: Hardware Support labels Jan 22, 2025
@blocktrron
Copy link
Member

Last time I've checked the LAN LED mismatched the state of plugged in ethernet cables - is this still the case?

@maurerle
Copy link
Member Author

Yes, I remember there was something.. Looks like I got distracted there.
I think it was set to netdev, just like
#2716 (comment)

I reflected this in the checklist.

@maurerle
Copy link
Member Author

Using something like
uci set system.led_lan.dev='lan1' && uci commit system && service led restart makes the LED blink on lan1 activity
closest is eth0 which is turned on by default and blinks if any of the ports are connected.

Related issue is #2756 - so this looks like a tough one.

Signed-off-by: Florian Maurer <[email protected]>
@github-actions github-actions bot removed the 3. topic: docs Topic: Documentation label Jan 25, 2025
@maurerle
Copy link
Member Author

Added as broken for now, with the same disclaimer as the TP-Link Archer C6 v3 - LAN LED not working - review after resolving #2756

@rotanid rotanid merged commit 7e61910 into freifunk-gluon:main Jan 26, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: hardware Topic: Hardware Support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mt7621: support TP-Link Archer AX23 / AX1800
3 participants