chore(aci milestone 3): refactor migration helper tests #84048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
mifu67
commented
Jan 24, 2025
| @@ -208,6 +210,178 @@ def setUp(self): | |||
| alert_rule_trigger=self.alert_rule_trigger_critical, | |||
| ) | |||
|
|
|||
| def mock_migrate_alert_rule(self, metric_alert) -> tuple[ | |||
There was a problem hiding this comment.
Right now, these mock migration helpers are pretty closely copying the logic of the actual migration helpers, with a few shortcuts because we can guarantee that correctly written to the database. We may want to hardcode more values or change things around—appreciate guidance on this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create methods mocking the ACI table data for a dual written
AlertRule,AlertRuleTrigger, or integration typeAlertRuleTriggerAction.