fix(aci milestone 3): always dual write resolution data conditions #84052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ceorourke
reviewed
Jan 25, 2025
| "organizations:workflow-engine-metric-alert-processing", alert_rule.organization | ||
| ): | ||
| # create the resolution data triggers once we've migrated the critical/warning triggers | ||
| migrate_resolve_threshold_data_conditions(alert_rule) |
There was a problem hiding this comment.
Does this need to be after _handle_triggers or can we put it below migrate_alert_rule and only check the flag once? If it has to be there then you could store whether the flag is enabled in a variable and use that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DataConditions that correspond to alert rule resolution should always be created, regardless of whether the resolution threshold is explicitly specified on the legacy alert rule. Migrate the resolve threshold after all the triggers have been migrated, because the logic for automatically determining the resolution threshold depends on their DataConditions existing.