Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter registry credentials by language #2680

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Filter registry credentials by language #2680

wants to merge 1 commit into from

Conversation

marcogario
Copy link
Contributor

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@marcogario marcogario self-assigned this Jan 10, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 10, 2025
View reviewed changes
src/start-proxy-action.ts
@@ -17,6 +17,11 @@
const KEY_SIZE = 2048;
const KEY_EXPIRY_YEARS = 2;

const LANGUAGE_TO_REGISTRY_TYPE: Record<string, string> = {
"java-kotlin": "maven_repository",
"csharp": "nuget_feed",

Check failure

Code scanning / ESLint

Ensure code is properly formatted, use insertion, deletion, or replacement to obtain desired formatting. Error

Replace "csharp" with csharp

Copilot Autofix AI about 7 hours ago

Beta Copilot Autofix for ESLint

To fix the problem, we need to remove the quotes around the key "csharp" in the LANGUAGE_TO_REGISTRY_TYPE object. This will ensure that the key is properly formatted according to the ESLint rule. The change should be made directly in the src/start-proxy-action.ts file.

Suggested changeset 1
src/start-proxy-action.ts

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/src/start-proxy-action.ts b/src/start-proxy-action.ts
--- a/src/start-proxy-action.ts
+++ b/src/start-proxy-action.ts
@@ -21,3 +21,3 @@
   "java-kotlin": "maven_repository",
-  "csharp": "nuget_feed",
+  csharp: "nuget_feed",
 };
EOF
@@ -21,3 +21,3 @@
"java-kotlin": "maven_repository",
"csharp": "nuget_feed",
csharp: "nuget_feed",
};
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

@marcogario marcogario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marcogario