C#: Adding synthetic implicit ToString calls in binary- and string interpolation expressions. #18446

michaelnebel · 2025-01-08T13:16:00Z

In this PR we get the ball rolling on synthesizing compiler generated ToString calls.
We introduce ToString calls in binary expressions for concatenating strings and string interpolation expressions:
That is,

"abc" + x -> "abc" + x.ToString()`
$"abx{x}" -> $"abx{x.ToString()}"

…ring calls into account.

…ons and generated ToString calls.

github-actions bot added the C# label Jan 8, 2025

michaelnebel force-pushed the csharp/implicittostring2 branch 2 times, most recently from 7ba7af1 to 9959976 Compare January 9, 2025 10:43

github-actions bot added the documentation label Jan 9, 2025

michaelnebel force-pushed the csharp/implicittostring2 branch 5 times, most recently from 04c455e to b586059 Compare January 10, 2025 08:57

michaelnebel added 7 commits January 10, 2025 13:10

C#: Add some implicit toString data flow test cases.

be53c2f

C#: Add a RedundantToStringCall test case.

e24f908

C#: Make synthetic ToString calls in binary add expressions.

2fb7fb5

C#: Update test expected output.

95e4b33

C#: Make synthetic ToString calls in string interpolation expressions.

a192afa

C#: Update test expected output.

5ae2cd7

C#: Modify compiler generated strip logic to also take generated ToSt…

a6a3881

…ring calls into account.

michaelnebel force-pushed the csharp/implicittostring2 branch from b586059 to bf46c42 Compare January 10, 2025 12:11

michaelnebel added 3 commits January 10, 2025 14:14

C#: Add PrintAst test to implicit ToString test.

678a8c5

C#: Update AST printing to include generated cast (wrapping) expressi…

61cca25

…ons and generated ToString calls.

C#: Update PrintAst expected test output.

1cff5e1

michaelnebel force-pushed the csharp/implicittostring2 branch from bf46c42 to 825c64f Compare January 10, 2025 13:17

michaelnebel changed the title ~~C#: Adding synthetic implicit ToString calls in binary expressions.~~ C#: Adding synthetic implicit ToString calls in binary- and string interpolation expressions. Jan 10, 2025

michaelnebel mentioned this pull request Jan 10, 2025

C#: Introduce synthetic ToString calls where appropriate. #18442

Closed

michaelnebel added 2 commits January 10, 2025 14:51

C#: Update other existing tests expected output.

cf8b34e

C#: Add change note.

9ebee34

michaelnebel force-pushed the csharp/implicittostring2 branch from 825c64f to 9ebee34 Compare January 10, 2025 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

C#: Adding synthetic implicit ToString calls in binary- and string interpolation expressions. #18446

C#: Adding synthetic implicit ToString calls in binary- and string interpolation expressions. #18446

michaelnebel commented Jan 8, 2025 •

edited

Loading

C#: Adding synthetic implicit ToString calls in binary- and string interpolation expressions. #18446

Are you sure you want to change the base?

C#: Adding synthetic implicit ToString calls in binary- and string interpolation expressions. #18446

Conversation

michaelnebel commented Jan 8, 2025 • edited Loading

michaelnebel commented Jan 8, 2025 •

edited

Loading