update-go-pkg(deps): bump github.com/Azure/azure-storage-blob-go from 0.10.0 to 0.15.0 #1859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
@dependabot rebase |
Bumps [github.com/Azure/azure-storage-blob-go](https://github.com/Azure/azure-storage-blob-go) from 0.10.0 to 0.15.0. - [Release notes](https://github.com/Azure/azure-storage-blob-go/releases) - [Changelog](https://github.com/Azure/azure-storage-blob-go/blob/master/ChangeLog.md) - [Commits](Azure/azure-storage-blob-go@v0.10.0...v0.15.0) --- updated-dependencies: - dependency-name: github.com/Azure/azure-storage-blob-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot/go_modules/main/github.com/Azure/azure-storage-blob-go-0.15.0
branch
from
ffa69b2 to
5a22b69
Compare
matt0x6F
reviewed
Feb 19, 2024
| @@ -129,7 +129,7 @@ func (s *azblobLock) acquireLease(ctx context.Context, blobURL azblob.BlockBlobU | |||
| defer cancel() | |||
|
|
|||
| // first we need to create a blob which can be then leased | |||
| _, err := blobURL.Upload(tctx, bytes.NewReader([]byte{1}), azblob.BlobHTTPHeaders{}, nil, azblob.BlobAccessConditions{}) | |||
| _, err := blobURL.Upload(tctx, bytes.NewReader([]byte{1}), azblob.BlobHTTPHeaders{}, nil, azblob.BlobAccessConditions{}, azblob.DefaultAccessTier, nil, azblob.ClientProvidedKeyOptions{}, azblob.ImmutabilityPolicyOptions{}) | |||
There was a problem hiding this comment.
I'm somewhat concerned about azblob.DefaultAccessTier because I don't really trust that the people who built this SDK mean "default" as in "what it used to be before I implemented object level priority".
There was a problem hiding this comment.
In terms of the SDK and Azure it translates to this:
// AccessTierNone represents an empty AccessTierType.
AccessTierNone AccessTierType = ""
So, I think this is what users would expect who are existing users of Azure Blob Storage.
There was a problem hiding this comment.
It seems like the right choice: Azure/azure-storage-blob-go@7b8190d#diff-3316a810df43ef6f2e17497d349af1b78a9738ddd70bea1cfadc8f3e5b820f08L78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/Azure/azure-storage-blob-go from 0.10.0 to 0.15.0.
Release notes
Sourced from github.com/Azure/azure-storage-blob-go's releases.
Changelog
Sourced from github.com/Azure/azure-storage-blob-go's changelog.
Commits
a95cc93Merge pull request #324 from Azure/dev3165aadUpdated version for 0.15 and added changelog (#323)69bf9ebMerge pull request #284 from kfarnung/chunkwriting_buffers7a7d02eMerge branch 'dev' into chunkwriting_buffers609d45cMerge pull request #322 from Azure/dev-master-merge36a3b7cRemoved swagger speca541006Merge remote-tracking branch 'origin/master' into devfcec3a3Added SAS Permission for Permanent Delete (#305)e7f2275Implement copy source authorization (#317)7e62913Rehydrate Priority In SetTier (#320)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)