-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Integrate TaskSequenceHandler with DataCollectionViewModel #2986
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # ground/src/main/java/com/google/android/ground/ui/datacollection/TaskSequenceHandler.kt
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2986 +/- ##
============================================
- Coverage 63.55% 63.33% -0.23%
+ Complexity 1242 1228 -14
============================================
Files 267 267
Lines 6506 6455 -51
Branches 911 905 -6
============================================
- Hits 4135 4088 -47
+ Misses 1785 1782 -3
+ Partials 586 585 -1
|
Let's hold this one until the latest release candidate is cut. |
The problem with current existing and proposed is that we aren't caching the value of sequence. It getting generated 5-10 times during each screen. Ideally, we only need to generate the sequence when data is updated. |
af94eb3
to
a511ecb
Compare
…value is emitted.
Fixes #2958
@... PTAL?