Replace httpbin references with QuickPizza #1833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicotdn
requested review from
oleiade and
codebien
and removed request for
a team
federicotdn
commented
Jan 10, 2025
|
|
||
| {{< /code >}} | ||
|
|
||
| ## Digest authentication |
There was a problem hiding this comment.
Digest auth is deprecated since 2011 (https://en.wikipedia.org/wiki/Digest_access_authentication) so I would not recommend users to implement it in their HTTP servers. I also think this auth method is not widely used nowadays - for this reason I've removed this section.
| @@ -71,33 +71,6 @@ export default function () { | |||
|
|
|||
| {{< /code >}} | |||
|
|
|||
| ### Example of Digest Authentication | |||
| jar.set('http://quickpizza.grafana-dev.com:3333/api/cookies', 'my_cookie', 'hello world', { | ||
| domain: 'quickpizza.grafana-dev.com', | ||
| path: '/api/cookies', | ||
| secure: false, // TODO set to false |
There was a problem hiding this comment.
Will undo secure changes once URLs are pointing at QP production.
| ```javascript | ||
| import http from 'k6/http'; | ||
| import { Trend, Rate, Counter, Gauge } from 'k6/metrics'; | ||
| import { sleep } from 'k6'; | ||
|
|
||
| export const TrendRTT = new Trend('RTT'); | ||
| export const RateContentOK = new Rate('Content OK'); | ||
| export const RateContentOK = new Rate('ContentOK'); |
There was a problem hiding this comment.
Test was failing due to space in the metric name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of https://github.com/grafana/k6-cloud/issues/2437.
Replace all uses of
httpbin.test.k6.iowith QuickPizza.NOTE: The URL used is currently
quickpizza.grafana-dev.com:3333. This is because I was testing the changes against a local server. I will change the URLs to the finalquickpizza.grafana.comsoon, but this can be reviewed already anyways.Also, once this is approved, I will backport the changes to previous OSS versions, to avoid making the PR diff larger now.
Checklist
npm startcommand locally and verified that the changes look good.docs/sources/k6/nextfolder of the documentation.docs/sources/k6/v{most_recent_release}folder of the documentation.docs/sources/k6/nextfolder of the documentation.Related PR(s)/Issue(s)