Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A87: mTLS SPIFFE Support #462

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

A87: mTLS SPIFFE Support #462

wants to merge 7 commits into from

Conversation

markdroth
Copy link
Member

@markdroth markdroth commented Oct 30, 2024

No description provided.

@markdroth markdroth marked this pull request as ready for review November 20, 2024 23:30
@markdroth markdroth requested review from ejona86 and dfawley November 20, 2024 23:32

#### Java

In Java, we need new API to work with [SPIFFE] and [SPIFFE bundle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is internal API, not public. This section documents how the xDS part is implemented, but it doesn't describe any changes to TlsCredentials for use outside of xDS.

### Temporary environment variable protection

The xDS functionality will be guarded via the
`GRPC_EXPERIMENTAL_XDS_MTLS_SPIFFE` environment variable. The new
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, GRPC_EXPERIMENTAL_SPIFFE_TRUST_BUNDLE_MAP was used in Java. I think that may be because the initial implementation pre-dates this gRFC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants