Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add nonce as attribute to script #414

Merged

Conversation

dariasamo
Copy link
Contributor

@dariasamo dariasamo commented Apr 3, 2024

Nonce attribute is not added as an attribute to the script tag, see:
gtm-support/vue-gtm#354
gtm-support/vue-gtm#413

Nonce was added as a property to the script object, but not rendered to the HTML script tag, which would cause script loading block with enabled CSP.

@dariasamo dariasamo requested a review from Shinigami92 as a code owner April 3, 2024 16:01
@Shinigami92 Shinigami92 added the bug Something isn't working label Apr 3, 2024
@Shinigami92 Shinigami92 merged commit 789bfbf into gtm-support:main Apr 3, 2024
7 checks passed
@Shinigami92
Copy link
Contributor

@dariasamo thx, I will release this tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants