-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit keyword to constructors #281
base: master
Are you sure you want to change the base?
Conversation
Resolves cppcheck warnings noExplicitConstructor, and useInitializationList.
Log
Also Do you think it's better to just create a new constructor which can take a uint16_t, or change such instances like this? I've gone with the latter (though I excluded the file from the commit for now), though adding the new constructor would probably make it easier to read Edit: Or this
|
I think |
Would this be considered a breaking change? Any applications making use of these implicit conversions will fail to compile, though the changes should be easy to make. |
It might be, depending on the application. I would suggest adding the HID changes to this PR so we can test the builds at least. Maybe add some more build tests to find where it may fail so it can be documented? |
d307e00
to
f9afdc9
Compare
Resolves cppcheck warnings noExplicitConstructor, useInitializationList, and passedByValue.