Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std::string_view cannot be constructed from nullptr #124

Merged
merged 1 commit into from
Dec 20, 2023
Merged

std::string_view cannot be constructed from nullptr #124

merged 1 commit into from
Dec 20, 2023

Conversation

mmomtchev
Copy link
Contributor

According to the C++ specs std::string_view cannot be constructed from nullptr and many compilers will produce a crashing code. Use the default constructor instead.

@h4tr3d
Copy link
Owner

h4tr3d commented Dec 20, 2023

Good job! Thanks

@h4tr3d h4tr3d merged commit c5ee87f into h4tr3d:master Dec 20, 2023
8 checks passed
@mmomtchev mmomtchev deleted the customio-crash branch December 20, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmomtchev @h4tr3d