Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Icon extractor #350

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Renzo904
Copy link
Member

@Renzo904 Renzo904 commented Dec 3, 2024

Using extract-icon-py and pefile, i extract the first(and only) icon of game.exe(i could have done it with just pefile, but i'm kinda lazy tbh), and use that icon in case we are using BINARY_MATCHBUILD build type.
Also, i added the function ZUN_ASSERT_SIZE(type, size) which just does a regular size assertion, but now it can be toggled off, i figured that we may need it on some future if we ever want a 64-bits build or just mess around
TODO:

  • Maybe a CI for later binary comparison? Of course, without any Artifacts, just comparison reports. But even then, i'm a little concerned about that, so i prefer not to do it for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant