test(e2e): add e2e test for scope chooser with filtered targets #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
ZedLi
reviewed
Jan 7, 2025
hashicc
force-pushed
the
ICU-16121/add-scope-chooser-e2e-tests
branch
from
a2eb3dd to
68638e7
Compare
hashicc
force-pushed
the
ICU-16121/add-scope-chooser-e2e-tests
branch
from
68638e7 to
69addb2
Compare
hashicc
force-pushed
the
ICU-16121/add-scope-chooser-e2e-tests
branch
from
69addb2 to
149eca4
Compare
calcaide
reviewed
Jan 7, 2025
calcaide
previously approved these changes
Jan 7, 2025
Move beforeEach and afterEach and the associated variables setup in hooks to top-level within scope.spec.js. This matches the patterns used in other tests.
DhariniJeeva
approved these changes
Jan 9, 2025
ZedLi
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an e2e test to ensure that the scope choose in the desktop app correctly filters the displayed targets.
Closes: https://hashicorp.atlassian.net/browse/ICU-16121
🎟️ Jira ticket
Screenshots (if appropriate)
How to Test
With enos and existing e2e setup working, run this command from the
e2e-testsfolder:Checklist
- [ ] I have added before and after screenshots for UI changes- [ ] I have added JSON response output for API changes- [ ] I have added steps to reproduce and test for bug fixes in the description- [ ] I have commented on my code, particularly in hard-to-understand areas- [ ] My changes generate no new warnings- [ ] I have added tests that prove my fix is effective or that my feature works