Support parseutil.ParsePath for sensitive values in wrapper configs #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will subsequently update the go.mod deps to a tagged version of go-kms-wrapping/v2 |
|
|
||
| func ParsePaths(fields ...*string) error { | ||
| for i := 0; i < len(fields); i++ { | ||
| if newVal, err := parseutil.ParsePath(*fields[i]); err != nil { |
There was a problem hiding this comment.
Shouldn't this trap errors.Is(err, ErrNotAUrl) and not return it leaving whatever the field value was previously?
I'm just wondering if we considered with these little tidbits but all three are me trying to poke holes and I don't feel strongly about them.
- If we were given any values that started or ended with spaces they will no longer work as ParsePath will trim them.
- It's a little unfortunate that with
env://values we don't get an error back saying it didn't exist which may be hard for operators to diagnose connection issues in the future, but we do for file based schemas - Obviously if the values being passed in had values beginning with file:// or env:// that were for some reason meant to be passed to the underlying wrapper there is no way out now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a few operators have asked for the ability to pull sensitive values into seal/managed key configs from separate files, feeling env vars or direct config isn't secure. ParsePath gives them the option to get values from a separate file while being non-invasive to existing configs.