Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace keyring dependency to address zombie dbus-daemons processes #29334

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

fairclothjm
Copy link
Contributor

Description

The keyring library has an outstanding bug that causes zombie dbus-daemon processes on each execution. This only happens on certain systems. Vault has an indirect dependency on keyring via gosnowflake. This replace is a stopgap measure until either gosnowflake or keyring addresses the issue.

See 99designs/keyring#103 and snowflakedb/gosnowflake#1183

Support has published 5 workarounds for this issue here: Vault 1.13.7+ and Linux DBus leftover processes. This has also been reported in GitHub: #22560. Additionally, some customers have reported that none of the workarounds resolve the issue.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@fairclothjm fairclothjm added this to the 1.18.4 milestone Jan 9, 2025
@fairclothjm fairclothjm requested a review from a team as a code owner January 9, 2025 21:38
@fairclothjm fairclothjm requested a review from zofskeez January 9, 2025 21:38
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

CI Results:
All Go tests succeeded! ✅

Copy link

github-actions bot commented Jan 9, 2025

Build Results:
All builds succeeded! ✅

@fairclothjm fairclothjm added backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/1.18.x backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent labels Jan 9, 2025
@fairclothjm fairclothjm enabled auto-merge (squash) January 9, 2025 21:42
@fairclothjm fairclothjm merged commit 49d8fb2 into main Jan 9, 2025
107 checks passed
@fairclothjm fairclothjm deleted the VAULT-33283/gosnowflake-replace-keyring branch January 9, 2025 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/ent/1.16.x+ent Changes are backported to 1.16.x+ent backport/ent/1.17.x+ent Changes are backported to 1.17.x+ent backport/1.18.x hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants