New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't open versioned shared libraries in wayland and x11 #1334

Open

xdBronch wants to merge 2 commits into hexops:main from xdBronch:dynlib

Contributor

xdBronch commented Jan 9, 2025

By selecting this checkbox, I agree to license my contributions to this project under the license(s) described in the LICENSE file, and I have the right to do so or have received permission to do so by an employer or client I am producing work for whom has this right.

xdBronch added 2 commits

January 9, 2025 01:35


          don't open versioned libraries

5cdeb5b


          narrow error sets

29f88df

Member

emidoots commented Jan 12, 2025

Have conflicts after merging #1332 first.

Also not convinced this is the right solution; I think we need to make all our DynLib usage:

Try to load the major-versioned name first
If it fails, log that it failed and that we are falling back to the unversioned symlink
Fallback to the unversioned symlink and try to continue

Can possibly be done as an implementation detail of mach.dynLibOpen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet