Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve background-editor background-attachment alignment #23615

Merged
merged 5 commits into from
Jan 7, 2025

Conversation

wendevlin
Copy link
Contributor

@wendevlin wendevlin commented Jan 7, 2025

Proposed change

  • Change button-group styling to be more flat
  • Improve background settings attachment button group

2025-01-07_13-41_1
2025-01-07_14-24

2025-01-07_14-12

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@wendevlin wendevlin added this to the 2025.1 milestone Jan 7, 2025
@wendevlin wendevlin changed the title add flex-end to toggle-button in background-editor Improve background-editor background-attachment alignment Jan 7, 2025
@wendevlin wendevlin marked this pull request as draft January 7, 2025 11:02
@bramkragten
Copy link
Member

I dont think this should be a css variable, but the default.

Compare it to a boolean selector, that is also right aligned. This should behave the same.

@wendevlin
Copy link
Contributor Author

wendevlin commented Jan 7, 2025

I dont think this should be a css variable, but the default.

Compare it to a boolean selector, that is also right aligned. This should behave the same.

👍 thanks, I did it now differently after feedback from @marcinbauer85

@wendevlin wendevlin marked this pull request as ready for review January 7, 2025 13:14
@bramkragten
Copy link
Member

Align the label in the center of the control

CleanShot 2025-01-07 at 14 17 21@2x

Like:

CleanShot 2025-01-07 at 14 18 22@2x

@wendevlin wendevlin merged commit 6e90afc into dev Jan 7, 2025
15 checks passed
@wendevlin wendevlin deleted the fix-bg-attachment-option-alignment branch January 7, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants