Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup summary label position #23655

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Fix backup summary label position #23655

merged 2 commits into from
Jan 9, 2025

Conversation

wendevlin
Copy link
Contributor

Proposed change

  • move backup summary label to top

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@wendevlin wendevlin added this to the 2025.1 milestone Jan 9, 2025
@NoRi2909
Copy link
Contributor

NoRi2909 commented Jan 9, 2025

In case you like to fix this here along the way:

cloud_agent_no_subcription

is missing an "s"

Copy link
Member

@piitaya piitaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wendevlin Can be change protected to protection as suggested by Matthias?

@wendevlin

This comment was marked as outdated.

@wendevlin
Copy link
Contributor Author

@NoRi2909 Oh I see you mean the key :D
the problem is that we loose then our translations 😒 lets keep it for now.

@NoRi2909
Copy link
Contributor

NoRi2909 commented Jan 9, 2025

@wendevlin Yes, I meant the key. Then better ship with complete translations now and fix that later.

@wendevlin wendevlin merged commit 31ed0f7 into dev Jan 9, 2025
15 checks passed
@wendevlin wendevlin deleted the fix-backup-summary-styles branch January 9, 2025 13:49
bramkragten pushed a commit that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants