Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add with_max builder, basic PermutedSlice impl, adjusted algo #1

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

hoxxep
Copy link
Owner

@hoxxep hoxxep commented Oct 27, 2023

Unfinished implementation for PermuteSlice trait and introduces the with_max builder setting to allow using RandomSequence for generating slice permutations.

TODO:

  • Improve the algorithm and/or seed with a hash to increase the number of permutations we're able to produce. With the lack of a seeded offset this algo only generates a very small number of permutations versus the total available permutations.
  • Revisit PermuteSlice implementation for a cleaner API and iterators, double check the behaviour/need for permute_mut.
  • Add permute-in-place for slice mut.

@hoxxep hoxxep marked this pull request as draft October 27, 2023 23:00
@hoxxep hoxxep mentioned this pull request Oct 30, 2023
@hoxxep hoxxep force-pushed the master branch 7 times, most recently from f5c316f to 44a2c61 Compare November 14, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant