-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vendor_version for build info #368
base: master
Are you sure you want to change the base?
Conversation
😊 Welcome @shamsher31! This is either your first contribution to the Istio pkg repo, or it's been You can learn more about the Istio working groups, code of conduct, and contributing guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO "vendor version" should not be a concept. For example:
"serverVersion": {
"major": "1",
"minor": "20+",
"gitVersion": "v1.20.6-gke.1400",
"gitCommit": "b7ccf3218bdb80cd2d66ed6186d78f18f1ef03c6",
"gitTreeState": "clean",
"buildDate": "2021-05-05T09:19:45Z",
"goVersion": "go1.15.10b5",
"compiler": "gc",
"platform": "linux/amd64"
}
GKE k8s version. The "vendor" aspect is just in the normal version
@shamsher31 in the build if VERSION is set it is used to link stamp binaries. We will now set that VERsIOn to the full version including Google specific extensions. Like 1.10.2-asm.5 |
@shamsher31: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
To fix istio/istio#33421